Fixes #2337: Refactor contributor routes for simpler nav/sub-nav templates. by miketaylr · Pull Request #2387 · webcompat/webcompat.com

miketaylr · 2018-04-11T20:25:07Z

…d by substring.

…emplate groups.

karlcow

My bad for NOT (edited) noticing this before. Aka the templates contained these rules with endpoint before, while we could have used rule. But we have an opportunity to change that. So I'm sending this with a weak request changes. Your PR is working as-is. but we probably don't have to change views.py

Sign in to view

 @app.route('/contributors/report-bug')
 @cache_policy(private=True, uri_max_age=0, must_revalidate=True)
-def contributors_report_bug():
+def contributors_bug_report():


Sign in to view

  </li>

-  <li class="sub-nav-item {% if request.url_rule.endpoint in ['contributors_report_bug', 'contributors_reproduce_bug', 'contributors_diagnose_bug', 'contributors_site_outreach'] %} active {% endif %}">
+  <li class="sub-nav-item {% if 'contributors_bug_' in request.url_rule.endpoint %} active {% endif %}">


Sign in to view

    </a>
    <ol class="nested-sub-nav">
-      <li class="nested-sub-nav-item {% if request.url_rule.endpoint == 'contributors_report_bug' %} sub-nav-active{% endif %}">
+      <li class="nested-sub-nav-item {% if request.url_rule.endpoint == 'contributors_bug_report' %} sub-nav-active{% endif %}">


Sign in to view

@@ -5,59 +5,59 @@
    </a>


miketaylr · 2018-04-12T13:58:54Z

Aka the templates contained these rules with endpoint before, while we could have used rule. But we have an opportunity to change that. So I'm sending this with a weak request changes.

Yep, makes sense! Happy to make the changes.

edit: looking at this more, I think it's a little nicer to use endpoint rather than rule. But if you feel strongly, we can re-do this. It just means the template is a little more verbose than my proposal.

miketaylr

(oops, left my comments as part of a Review)

Sign in to view

    </a>
    <ol class="nested-sub-nav">
-      <li class="nested-sub-nav-item {% if request.url_rule.endpoint == 'contributors_report_bug' %} sub-nav-active{% endif %}">
+      <li class="nested-sub-nav-item {% if request.url_rule.endpoint == 'contributors_bug_report' %} sub-nav-active{% endif %}">


Sign in to view

  </li>

-  <li class="sub-nav-item {% if request.url_rule.endpoint in ['contributors_report_bug', 'contributors_reproduce_bug', 'contributors_diagnose_bug', 'contributors_site_outreach'] %} active {% endif %}">
+  <li class="sub-nav-item {% if 'contributors_bug_' in request.url_rule.endpoint %} active {% endif %}">


Sign in to view

        </li>
-        <li class="footer-item{% if request.url_rule.endpoint in
-        ['contributors_build_tools', 'contributors_web_platform_research', 'contributors_organize_webcompat_events', 'contributors', 'contributors_report_bug', 'contributors_reproduce_bug', 'contributors_diagnose_bug', 'contributors_site_outreach'] %} active{% endif %}">
+        <li class="footer-item{% if 'contributors' in request.url_rule.endpoint %} active{% endif %}">


Sign in to view


 <!-- sub nav for contribute > working with bugs -->
-      {% if request.url_rule.endpoint in ['contributors_report_bug', 'contributors_reproduce_bug', 'contributors_diagnose_bug', 'contributors_site_outreach'] %}
+      {% if 'contributors_bug_' in request.url_rule.endpoint %}


Sign in to view


 <!-- sub nav for contribute > other contributions -->
-      {% if request.url_rule.endpoint in ['contributors_build_tools', 'contributors_web_platform_research', 'contributors_organize_webcompat_events'] %}
+      {% if 'contributors_other_' in request.url_rule.endpoint %}


karlcow

ok understood! Indeed it makes sense.

@miketaylr Thanks for the explanations. Super useful.

miketaylr · 2018-04-12T22:03:01Z

Thanks @karlcow for your review, I didn't know about request.url_rule.rule. 🎈

karlcow · 2018-04-12T23:51:00Z

As a kind of followup on this #2391

miketaylr added 2 commits April 11, 2018 15:22

Issue #2337. Rename contributors-related routes so they can be groupe…

40b8353

…d by substring.

Issue #2337. Update footer and sub-nav templates to use contributor t…

abceb18

…emplate groups.

miketaylr requested a review from karlcow April 11, 2018 20:25

miketaylr added the in progress label Apr 11, 2018

karlcow requested changes Apr 12, 2018

View reviewed changes

miketaylr commented Apr 12, 2018

View reviewed changes

karlcow approved these changes Apr 12, 2018

View reviewed changes

karlcow merged commit e205f37 into master Apr 12, 2018

karlcow added status: add to changelog and removed in progress labels Apr 12, 2018

miketaylr deleted the issues/2337/1 branch April 12, 2018 22:02

miketaylr removed the status: add to changelog label Apr 17, 2018

Conversation

miketaylr commented Apr 11, 2018

Uh oh!

karlcow left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

miketaylr commented Apr 12, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

miketaylr left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

karlcow left a comment

Choose a reason for hiding this comment

Uh oh!

miketaylr commented Apr 12, 2018

Uh oh!

karlcow commented Apr 12, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

karlcow left a comment •

edited

Loading

miketaylr commented Apr 12, 2018 •

edited

Loading