Fixes #2465 - Upgrades Flask to 1.0.2#2485
Merged
miketaylr merged 1 commit intowebcompat:masterfrom Jun 7, 2018
Merged
Conversation
Travis tests have failedHey @karlcow, 1st Buildnosetestsnpm run test:js -- --reporters="runner" --firefoxBinary=`which firefox` |
Member
Author
|
huh travis what did you find? 😄 |
Member
Author
Working for me locally. |
Member
Author
Member
Author
|
That's better. Next will be #2463 once this one is merged. |
Member
Yeah, seems like Travis just fails to start tests half the time... annoying. #2375 |
miketaylr
approved these changes
Jun 7, 2018
Member
miketaylr
left a comment
There was a problem hiding this comment.
Looking thru http://flask.pocoo.org/docs/1.0/upgrading/, I don't see anything to worry about here.
Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR fixes issue #2465
Proposed PR background
This upgrades to the first stable release of Flask.
It is a step that will help us improve logging and the switch to python3
Functional tests and unit tests are passing.
r? @miketaylr