Fixes #2762 - Removes the autolinking on adding contact#2833
Merged
karlcow merged 1 commit intowebcompat:masterfrom Apr 12, 2019
Merged
Fixes #2762 - Removes the autolinking on adding contact#2833karlcow merged 1 commit intowebcompat:masterfrom
karlcow merged 1 commit intowebcompat:masterfrom
Conversation
This comment was marked as spam.
This comment was marked as spam.
miketaylr
approved these changes
Apr 4, 2019
Member
miketaylr
left a comment
miketaylr
left a comment
There was a problem hiding this comment.
r+ on the code changes.
I get the feeling that "Submitted in the name of @foo can also be confusing.
@adamopenweb can we get a second opinion? Any ideas on how we can improve the language?
Collaborator
|
I agree it could be confusing the way it's written now. But I'm struggling to come up with an easy way to describe that, while keeping it short. |
Member
Author
|
Maybe something like
We could even make the maybe a link to the issue and/or an additional docs item in webcompat.com |
Member
Author
|
@miketaylr @adamopenweb on wording above. |
Collaborator
|
I'm good with that. It's possibly still confusing for some, but I think is an improvement. 😄 |
Member
Author
|
ok cool! Let's merge then. We can improve moar later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #2762 and #2791
Proposed PR background
The intent here is to avoid the auto-notification for people having their names added into the issue being reported.
It also slighly modifies the text to make it clear that it's not necessary reported by this person.