Fixes #2952 - Fixes husky pre-commit deprecation#3102
Merged
miketaylr merged 1 commit intowebcompat:masterfrom Dec 4, 2019
magbello157:2952/1
Merged
Fixes #2952 - Fixes husky pre-commit deprecation#3102miketaylr merged 1 commit intowebcompat:masterfrom magbello157:2952/1
miketaylr merged 1 commit intowebcompat:masterfrom
magbello157:2952/1
Conversation
Member
|
Thanks @meetmuhd! (Just got back from time off, sorry for the delay) |
miketaylr
approved these changes
Dec 4, 2019
miketaylr
changed the title
Member
|
@meetmuhd one small nit, when opening a PR please give a title of the following format:
|
Author
Oh my bad! I think I mistakenly put what was meant to be the title into a comment instead. My apologies please. And thank you so much for the merge and feedback! @miketaylr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #2952
Proposed PR background
Removes the "precommit" key from "scripts" in package.json since that is deprecated and moved to husky.hooks. This eliminates the warning message seen when one makes a commit.