Fixes #3139 - Implement first stages of private reporting flow#3147
Merged
Fixes #3139 - Implement first stages of private reporting flow#3147
Conversation
added 3 commits
January 10, 2020 13:26
miketaylr
commented
Jan 10, 2020
miketaylr
commented
Jan 11, 2020
karlcow
requested changes
Jan 13, 2020
Member
karlcow
left a comment
karlcow
left a comment
There was a problem hiding this comment.
so I understand the logic of most of the code, and I understand the urgency.
- There is one question about anonymous reporting button
- I have the feeling, we try to modify too much of the initial code instead of relying on what already exists. Basically the PR could probably be simpler with a smaller footprint. See my suggestions. I may have missed something in the logic.
added 5 commits
January 13, 2020 11:30
This first files a public issues, with some placeholder text, then uses its public URL to add to a private issue's metadata (which contains the original reporter's data).
We don't want to return any info here, let's be explicit.
They're not amazing, but it's something.
miketaylr
force-pushed
the
issues/3139/1
branch
3 times, most recently
from
4f2bfa8 to
6b655ec
Compare
Member
Author
|
OK, @karlcow, ready for re-review. Thanks for the suggestions so far! |
karlcow
requested changes
Jan 13, 2020
Member
karlcow
left a comment
karlcow
left a comment
There was a problem hiding this comment.
@miketaylr I have reviewed again. one thing to change.
added 2 commits
January 13, 2020 16:13
This allows us to pass in arbitrary metadata keys and values to be "wrapped" as HTML comments for the issue body
miketaylr
force-pushed
the
issues/3139/1
branch
from
6b655ec to
fff9a49
Compare
Member
Author
|
OK, pushed a fix! |
karlcow
approved these changes
Jan 13, 2020
Member
|
@miketaylr Thanks for the code, the pasta 🍝 and everything. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @karlcow
The next one to tackle is probably #3146.