Issue #3208 - Use more Pythonic get default value#3218
Merged
karlcow merged 1 commit intowebcompat:masterfrom Feb 27, 2020
Merged
Issue #3208 - Use more Pythonic get default value#3218karlcow merged 1 commit intowebcompat:masterfrom
karlcow merged 1 commit intowebcompat:masterfrom
Conversation
The second argument for `get` on mapping objects is the default value when the key is not found. See https://docs.python.org/3/library/stdtypes.html#dict.get. The default value we use is a value accepted by `strtobool` so we can move the conversion on the same line.
karlcow
approved these changes
Feb 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #3208
Proposed PR background
The second argument for
geton mapping objects is the default value when the key is not found. See https://docs.python.org/3/library/stdtypes.html#dict.get.The default value we use is a value accepted by
strtoboolso we can move the conversion on the same line.