Fixes #3289 - Add support for nested ul in browser details#3290
Merged
Fixes #3289 - Add support for nested ul in browser details#3290
Conversation
(This will be used by the GPU data, if it exists)
karlcow
requested changes
Apr 20, 2020
Member
karlcow
left a comment
karlcow
left a comment
There was a problem hiding this comment.
- maybe change the name
- double check that we are not doing at two places the same thing.
added 3 commits
April 22, 2020 14:50
And have it return the whole <ul>
Also, move get_details_list into helpers.
Member
Author
karlcow
approved these changes
Apr 22, 2020
Member
karlcow
left a comment
karlcow
left a comment
There was a problem hiding this comment.
Thanks @miketaylr
more elegant!
| def get_list_items(val_dict): | ||
| """Return list items (<li>) from the passed in list ([]).""" | ||
| rv = ''.join(['<li>{k}: {v}</li>'.format(k=k, v=get_serialized_value(v)) | ||
| for k, v in list(val_dict.items())]) |
Member
There was a problem hiding this comment.
The code was inherited from probably the conversion from python 2 to python 3. IN this specific case val_dict.items() is a <class 'dict_items'> and is an iterable, which makes the list() wrapper unecessary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(This will be used by the GPU data, if it exists)
I feel like Karl will have some opinions on this one, and it's cosmetic, so it can wait for him to come back.