Fixes #3295 - Fetch and render existing issue comments as HTML#3308
Merged
Fixes #3295 - Fetch and render existing issue comments as HTML#3308
Conversation
miketaylr
commented
May 15, 2020
miketaylr
force-pushed
the
issues/3295/1
branch
3 times, most recently
from
cf63e11 to
e9533e3
Compare
Member
Author
|
So I decided to just do away with the CommentsView and Collection and Model, etc. Instead we'll go old-school, and after doing an XHR post for new comments, we just append the HTML the server sends back to us. The cool thing about this is it means we no longer need the Markdown client stuff, so we can delete a ton of code here. |
miketaylr
commented
May 16, 2020
miketaylr
commented
May 16, 2020
miketaylr
commented
May 17, 2020
miketaylr
force-pushed
the
issues/3295/1
branch
2 times, most recently
from
c482f91 to
ced813d
Compare
Member
Author
Member
Author
|
🥳 |
miketaylr
commented
May 18, 2020
miketaylr
commented
May 18, 2020
miketaylr
commented
May 19, 2020
ksy36
reviewed
May 19, 2020
ksy36
approved these changes
May 19, 2020
miketaylr
force-pushed
the
issues/3295/1
branch
3 times, most recently
from
9b7f9dc to
55535e2
Compare
karlcow
requested changes
May 20, 2020
Member
karlcow
left a comment
karlcow
left a comment
There was a problem hiding this comment.
yoohoo. Wunderbar. Thanks @miketaylr for working on this. we are approaching a better system.
added 5 commits
May 20, 2020 15:31
Or at least, the first 100. Future work will make sure we get all of it.
We can get rid of the clientside handling of all of this now.
added 8 commits
May 20, 2020 15:31
This file will be returned when POSTing a new comment in test mode, so our existing functional tests can pass. When doing a GET, it will serve /tests/fixtures/api/issues/100/comments.38e6a9ddcea3ef150105b48bcd1c18f3.json because it has a ?per_page=100 param.
Now we rely on everything coming back from GitHub before rendering, so there's no more need for this.
miketaylr
force-pushed
the
issues/3295/1
branch
2 times, most recently
from
f4fccb0 to
c9c81eb
Compare
Co-authored-by: Karl Dubost <kdubost+github@mozilla.com>
Member
Author
Member
Author
|
yay! @ksy36 ok, you can rebase your form-v2 branch, promise i won't touch build configs for a while ^__^ |
Contributor
|
sounds good, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO:
get_response_headers