Fixes #3401 - Don't modify the file_path inside bust_cache#3407
Merged
Fixes #3401 - Don't modify the file_path inside bust_cache#3407
Conversation
miketaylr
force-pushed
the
issues/3401/2
branch
2 times, most recently
from
1f686e6 to
558507a
Compare
ksy36
approved these changes
Jul 20, 2020
Contributor
ksy36
left a comment
ksy36
left a comment
There was a problem hiding this comment.
looks good to me, just one nit-pick
| if file_path.startswith('/'): | ||
| file_path = file_path[1:] | ||
| absolute_path = os.path.join(STATIC_PATH, file_path) | ||
| trimmed_file_path = file_path[1:] |
Contributor
There was a problem hiding this comment.
not an expert, but maybe a bit shorter version:
trimmed_file_path = file_path
if file_path.startswith('/'):
trimmed_file_path = file_path[1:]
absolute_path = os.path.join(STATIC_PATH, trimmed_file_path)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Actually fixes it this time.
(Modifying the file_path var had bad consequences for some of the files, they could end up as 404)
r? @ksy36