Fixes #3419 - Make image upload keyboard navigable#3470
Merged
Conversation
added 3 commits
August 26, 2020 16:59
This allows users to hit Enter to open the file dialog.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Member
Author
|
It seems like the workaround that was in place for a chromedriver bug crashed geckodriver. And all the tests pass with it removed, so... |
ksy36
reviewed
Aug 27, 2020
ksy36
approved these changes
Aug 27, 2020
…ckodriver. I think?
miketaylr
force-pushed
the
issues/3419/1
branch
from
d8b72d2 to
153d5d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @ksy36