Fixes #3467 - Comment the reason why an issue was accepted but closed#3472
Merged
Fixes #3467 - Comment the reason why an issue was accepted but closed#3472
Conversation
added 3 commits
August 31, 2020 15:26
… for invalid and incomplete issues
(This helps me test it later, and it seems good anyways)
miketaylr
force-pushed
the
issues/3467/1
branch
from
ed2b438 to
5061a17
Compare
This comment has been minimized.
This comment has been minimized.
miketaylr
force-pushed
the
issues/3467/1
branch
2 times, most recently
from
45426a4 to
8d7954b
Compare
added 2 commits
September 1, 2020 13:37
miketaylr
force-pushed
the
issues/3467/1
branch
from
8d7954b to
72d0005
Compare
karlcow
approved these changes
Sep 2, 2020
Member
karlcow
left a comment
karlcow
left a comment
There was a problem hiding this comment.
👍 Good idea. The comments will give a better understanding too. and indeed for the ML will improve things.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @karlcow
No rush on the review.