Skip to content

replaced bot_ with oauth#756

Merged
karlcow merged 1 commit intowebcompat:masterfrom
haseebgit:master
Oct 12, 2015
Merged

replaced bot_ with oauth#756
karlcow merged 1 commit intowebcompat:masterfrom
haseebgit:master

Conversation

@haseebgit
Copy link
Copy Markdown
Member

No description provided.

@karlcow
Copy link
Copy Markdown
Member

karlcow commented Oct 12, 2015

@haseebgit Thanks for the contribution.

A couple of things when contributing.

  • Create a branch with the issue number, I guess here you are referring to Replace BOT_OAUTH_TOKEN with OAUTH_TOKEN #754
    So you could have done git checkout -b 754/1
  • When doing commits, you can add the issue number for example above you could have done #754 replaced bot_ with oauth. That will link automatically the issue you are working on. When it's the last commit in a series of commits, you can even do fix #754 replaced bot_ with oauth. That will automatically close the issue when merged.
  • When finished your commits, ask for a review with the syntax r? @miketaylr or r? @karlcow for python

See https://github.com/webcompat/webcompat.com/blob/master/CONTRIBUTING.md#submission-guidelines for details

Reviewed r+ by me.
@miketaylr be careful of updating travis.

karlcow added a commit that referenced this pull request Oct 12, 2015
fix #754 replaced bot_ with oauth
@karlcow karlcow merged commit 14e5c7f into webcompat:master Oct 12, 2015
@miketaylr
Copy link
Copy Markdown
Member

Cool, I'll create an issue to update Travis environment variables before we deploy this change.

@miketaylr
Copy link
Copy Markdown
Member

Oops, missed one in run.py:

🐓 python run.py 
Traceback (most recent call last):
  File "run.py", line 22, in <module>
    from webcompat import app
  File "/Users/miket/dev/compat/webcompat.com/webcompat/__init__.py", line 28, in <module>
    import webcompat.views
  File "/Users/miket/dev/compat/webcompat.com/webcompat/views.py", line 29, in <module>
    from issues import report_issue
  File "/Users/miket/dev/compat/webcompat.com/webcompat/issues.py", line 19, in <module>
    BOT_TOKEN = app.config['BOT_OAUTH_TOKEN']
KeyError: 'BOT_OAUTH_TOKEN'

@miketaylr
Copy link
Copy Markdown
Member

Also here:

Traceback (most recent call last):
  File "run.py", line 22, in <module>
    from webcompat import app
  File "/Users/miket/dev/compat/webcompat.com/webcompat/__init__.py", line 28, in <module>
    import webcompat.views
  File "/Users/miket/dev/compat/webcompat.com/webcompat/views.py", line 29, in <module>
    from issues import report_issue
  File "/Users/miket/dev/compat/webcompat.com/webcompat/issues.py", line 19, in <module>
    BOT_TOKEN = app.config['BOT_OAUTH_TOKEN']
KeyError: 'BOT_OAUTH_TOKEN'

@miketaylr
Copy link
Copy Markdown
Member

I pushed a fix so we aren't stuck here:

37efa68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants