Issue #930 - Fix QR code style issues

[dshgna]

r? @magsout @miketaylr @tagawa

[magsout]

thanks @dshgna .

I will review tonight. But I'm no more a big fan for float right. Maybe a flex would be more appropriate here.

[miketaylr]

I'll leave review to @magsout -- he's the resident CSS master.

I see there's a merge conflict, so might be good to rebase this branch against master. @dshgna let me know if you need help with that!

[dshgna]

@miketaylr Thanks! Rebased the commit, but am unsure if the resolved merge conflicts give the intended results. Could you please verify from the screenshot?

[magsout]

@dshgna there is some trouble in small screen

1. due to this issue Width of Comment on Small screen #940, not you fault (mine)

and

For fix the second issue. if you can add one <div></div> around all element except wc-Comment-qr.

And add justify-content: space-between in wc-Comment-header

except this minore issue, looks good.
good job @dshgna and thanks

[dshgna]

Thanks @magsout for the great review! I will how to the page works on different device sizes before committing in future.

[magsout]

Awesome, LGTM @dshgna .

Just need to figure why travis have failed the tests

[magsout]

For me, it's ok to merged, there is no reason at all Travis failed. But I prefere to wait your validation @miketaylr

[miketaylr]

Great, thanks!

[miketaylr]

Just need to figure why travis have failed the tests

Travis will fail all PRs from a fork -- because we rely on having secret ENV VARs with some login and password info for the bot.

See https://docs.travis-ci.com/user/encryption-keys/ for how we encrypt the username and password, before storing them with Travis.

BUT I just saw https://docs.travis-ci.com/user/pull-requests#Security-Restrictions-when-testing-Pull-Requests, which shows how we could run a subset of tests that don't require auth, which might be a nice compromise!