Add spec for newline detection - #210
Merged
Merged
Conversation
webdevred
marked this pull request as ready for review
August 8, 2026 21:56
hSetNewlineMode only applies to text-mode writes, so the ByteString output went straight past it and every file came out with LF. Rewrite the endings in the text instead. Makes the ENABLE_WINDOWS_NEWLINES flag redundant.
The prefix had a stray g in it, so the branch never fired and a CRLF file still lost the newline after the comment opener.
A newer local hpack rewrote the whole file, which the cabal file check rejects. Only the windows newlines block should have gone.
It feeds the tool a blob but compares against the working tree, so the two sides disagree about endings on Windows. The endings themselves have their own check now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failing spec that defines the contract for a newline detector, ahead of the implementation (TDD).
test/Core/NewlineSpec.hsexpectsdetectNewline :: Text -> NewlineinJbeamEdit.Core.Newline, reusing base'sSystem.IO.Newline(LF/CRLF) rather than a bespoke type. Cases: unix\nis LF, windows\r\nis CRLF, mixed endings are CRLF, and text without a line ending defaults to LF.The suite does not compile until
detectNewlineexists, so this branch is red on purpose.Relates to #209.