Skip to content

fix(disableBlinkingCursor): caret-color was not applied in shadowdom … #1079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 29, 2025
Merged

fix(disableBlinkingCursor): caret-color was not applied in shadowdom … #1079

merged 1 commit into from
Nov 29, 2025
+7 −2

Conversation

@plusgut
Copy link
Contributor

@plusgut plusgut commented Nov 28, 2025

Fixes #1078

The selector was to specific, and doesn't reach elements inside shadow-dom. With the wildcard selector the caret-color gets inherited.

@changeset-bot
Copy link

changeset-bot bot commented Nov 28, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 7edbc6e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@wdio/visual-service Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 28, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: plusgut / name: Carlo Jeske (7edbc6e)

@plusgut plusgut marked this pull request as draft November 28, 2025 11:16
@plusgut
fix(disableBlinkingCursor): caret-color was not applied in shadowdom w…
7edbc6e 
…ebdriverio#1078

Selectors of the outside document dont penetrate the shadowdom, therefore the inheritance of css should be used
@plusgut plusgut force-pushed the disable-blinking-cursor-shadowdom branch from 44dc4d7 to 7edbc6e Compare November 28, 2025 19:03
@plusgut plusgut marked this pull request as ready for review November 28, 2025 19:03
wswebcreation
wswebcreation approved these changes Nov 29, 2025
View reviewed changes
Copy link
Member

@wswebcreation wswebcreation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, thanks!

@wswebcreation wswebcreation merged commit 5fbbc02 into webdriverio:main Nov 29, 2025
6 of 11 checks passed
@wdio-bot
Copy link
Contributor

wdio-bot commented Nov 29, 2025

Hey plusgut 👋

Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution.

We've sent you an email with further instructions on how to claim your expenses from our development fund.
Please make sure to check your spam folder as well. If you have any questions, feel free to reach out to us at expense@webdriver.io or in the contributing channel on Discord.

We are looking forward to more contributions from you in the future 🙌

Have a nice day,
The WebdriverIO Team 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wswebcreation wswebcreation wswebcreation approved these changes

Assignees

No one assigned

Labels

Expensable $25 💸

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cursor inside shadow is shown, even with disableBlinkingCursor

3 participants

@plusgut @wdio-bot @wswebcreation