-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
fix: detect stale elements in BiDi mode for getCSSProperty (#14885) #14886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: detect stale elements in BiDi mode for getCSSProperty (#14885) #14886
Conversation
…io#14885) Added isConnected checks in browser.execute callbacks to throw stale element errors when elements are detached. This triggers proper element refetch via existing middleware, fixing infinite loops in waitForDisplayed when using BiDi protocol. Fixes webdriverio#14885
|
@christian-bromann please review |
create-wdio
eslint-plugin-wdio
@wdio/allure-reporter
@wdio/appium-service
@wdio/browser-runner
@wdio/browserstack-service
@wdio/cli
@wdio/concise-reporter
@wdio/config
@wdio/cucumber-framework
@wdio/dot-reporter
@wdio/firefox-profile-service
@wdio/globals
@wdio/jasmine-framework
@wdio/json-reporter
@wdio/junit-reporter
@wdio/lighthouse-service
@wdio/local-runner
@wdio/logger
@wdio/mocha-framework
@wdio/protocols
@wdio/repl
@wdio/reporter
@wdio/runner
@wdio/sauce-service
@wdio/shared-store-service
@wdio/smoke-test-cjs-service
@wdio/smoke-test-reporter
@wdio/smoke-test-service
@wdio/spec-reporter
@wdio/static-server-service
@wdio/sumologic-reporter
@wdio/testingbot-service
@wdio/types
@wdio/utils
@wdio/webdriver-mock-service
@wdio/xvfb
webdriver
webdriverio
commit: |
christian-bromann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome , LGTM 👍
|
Hey mccmrunal 👋 Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution. We've sent you an email with further instructions on how to claim your expenses from our development fund. We are looking forward to more contributions from you in the future 🙌 Have a nice day, |
Added isConnected checks in browser.execute callbacks to throw stale element errors when elements are detached. This triggers proper element refetch via existing middleware, fixing infinite loops in waitForDisplayed when using BiDi protocol.
Fixes #14885
Proposed changes
n v9.20.1, getCSSProperty was updated to always use browser.execute with window.getComputedStyle. Under the BiDi protocol, this causes isDisplayed to make two script.callFunction calls on the same sharedId element.
When the DOM re-renders or the element is not yet attached, that sharedId becomes stale. However, BiDi does not throw a stale-element error. Instead, it returns harmless values like false or an empty string.
Because no stale-element error is raised, WebdriverIO never triggers refetchElement. As a result, waitForDisplayed keeps polling the stale reference until timeout, even if a fresh, visible element matching the selector appears.
In v9.20.0, the older getElementCSSValue implementation did throw stale-element errors. That allowed elements to be refetched properly and prevented this regression.
Add isconnected to check if element is stale
//: # (Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.)
Types of changes
Checklist
Backport Request
//: # (The current
mainbranch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against thev8branch.)v9and doesn't need to be back-ported#XXXXXFurther comments
Reviewers: @webdriverio/project-committers