fix: TypeScript 7 compatibility

[mscrivo]

Proposed changes

fixes #15116

Types of changes

• Polish (an improvement for an existing feature)
• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update (improvements to the project's docs)
• Specification changes (updates to WebDriver command specifications)
• Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

• I have read the CONTRIBUTING doc
• I have added tests that prove my fix is effective or that my feature works
• I have added the necessary documentation (if appropriate)
• I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

• This change is solely for v9 and doesn't need to be back-ported
• Back-ported PR at #XXXXX

Further comments

Reviewers: @webdriverio/project-committers

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: mscrivo / name: Michael Scrivo (68b7810)

[christian-bromann]

@mscrivo is this a backwards compatible fix?

[mscrivo]

@christian-bromann I believe so, TS 5 doesn't raise TS1540 for this pattern AFAIK. I double checked in my repo with the repro.

[christian-bromann]

Thanks LGTM 👍

[pkg-pr-new]

Open in StackBlitz

create-wdio

npm i https://pkg.pr.new/webdriverio/webdriverio/create-wdio@15135

eslint-plugin-wdio

npm i https://pkg.pr.new/webdriverio/webdriverio/eslint-plugin-wdio@15135

@wdio/allure-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/allure-reporter@15135

@wdio/appium-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/appium-service@15135

@wdio/browser-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browser-runner@15135

@wdio/browserstack-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browserstack-service@15135

@wdio/cli

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cli@15135

@wdio/concise-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/concise-reporter@15135

@wdio/config

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/config@15135

@wdio/cucumber-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cucumber-framework@15135

@wdio/dot-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/dot-reporter@15135

@wdio/firefox-profile-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/firefox-profile-service@15135

@wdio/globals

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/globals@15135

@wdio/jasmine-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/jasmine-framework@15135

@wdio/json-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/json-reporter@15135

@wdio/junit-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/junit-reporter@15135

@wdio/lighthouse-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/lighthouse-service@15135

@wdio/local-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/local-runner@15135

@wdio/logger

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/logger@15135

@wdio/mocha-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/mocha-framework@15135

@wdio/protocols

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/protocols@15135

@wdio/repl

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/repl@15135

@wdio/reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/reporter@15135

@wdio/runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/runner@15135

@wdio/sauce-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sauce-service@15135

@wdio/shared-store-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/shared-store-service@15135

@wdio/smoke-test-cjs-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-cjs-service@15135

@wdio/smoke-test-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-reporter@15135

@wdio/smoke-test-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-service@15135

@wdio/spec-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/spec-reporter@15135

@wdio/static-server-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/static-server-service@15135

@wdio/sumologic-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sumologic-reporter@15135

@wdio/testingbot-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/testingbot-service@15135

@wdio/types

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/types@15135

@wdio/utils

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/utils@15135

@wdio/webdriver-mock-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/webdriver-mock-service@15135

@wdio/xvfb

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/xvfb@15135

webdriver

npm i https://pkg.pr.new/webdriverio/webdriverio/webdriver@15135

webdriverio

npm i https://pkg.pr.new/webdriverio/webdriverio@15135

commit: de2e47a

[mscrivo]

any idea when this can be merged? it's preventing us from being able to upgrade to any newer versions of typescript 7 after they introduced this new check in early Feb.

[dprevost-LMI]

🤔 Could it be breaking? But the passing pipeline and the last comment seem to make me beleive it is not 😅

swapping declare namespace NodeJS { … } for declare module NodeJS { … } (or having both) can break things, usually by making your augmentation not apply (or apply in the wrong “space”), which then cascades into type errors elsewhere.