Skip to content

fix(cc-task): TaskList onTaskSelected callback#466

Merged
mkesavan13 merged 1 commit into
webex:ccwidgetsfrom
mkesavan13:onSelectionChange
Jun 3, 2025
Merged

fix(cc-task): TaskList onTaskSelected callback#466
mkesavan13 merged 1 commit into
webex:ccwidgetsfrom
mkesavan13:onSelectionChange

Conversation

@mkesavan13

@mkesavan13 mkesavan13 commented Jun 3, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

PARTIALLY COMPLETES CAI-6283

This pull request addresses

TaskList component today does not let the developers know when a change in selection happens. This PR is raised to address this gap

by making the following changes

  • Add onTaskSelected Prop to TaskList component
  • Update the store to set a new task selected call back
  • Make call to this call back every time the currentTask is set to an actual task object. It won't be called if task or currentTask is null or if the set task is same as the current task

Vidcast Demo

https://app.vidcast.io/share/917186b3-61f1-403e-9a4b-804b91887183

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios were tested

  • The testing is done with the amplify link
  • Changing tasks when there are multiple tasks accepted
  • Station Relogin with an existing task in place
  • Accepting an incoming task
  • Wrapping up one task when there are multiple tasks

The GAI Coding Policy And Copyright Annotation Best Practices

  • GAI was not used (or, no additional notation is required)
  • Code was generated entirely by GAI
  • GAI was used to create a draft that was subsequently customized or modified
  • Coder created a draft manually that was non-substantively modified by GAI (e.g., refactoring was performed by GAI on manually written code)
  • Tool used for AI assistance (GitHub Copilot / Other - specify)
    • Github Copilot
    • Other - Please Specify
  • This PR is related to
    • Feature
    • Defect fix
    • Tech Debt
    • Automation

Checklist before merging

  • I have not skipped any automated checks
  • All existing and new tests passed
  • I have updated the testing document

@coderabbitai

coderabbitai Bot commented Jun 3, 2025

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@mkesavan13 mkesavan13 added the validated Indicates that the PR is ready for actions label Jun 3, 2025
@aws-amplify-us-east-2

aws-amplify-us-east-2 Bot commented Jun 3, 2025

Copy link
Copy Markdown

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-466.d1b38q61t1z947.amplifyapp.com

@mkesavan13 mkesavan13 changed the title fix(cc-task): onTaskSelected callback fix(cc-task): TaskList onTaskSelected callback Jun 3, 2025
rsarika
rsarika approved these changes Jun 3, 2025
View reviewed changes

@rsarika rsarika left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes looks good to me. But cant they rely on store.currentTask ?

@mkesavan13

mkesavan13 commented Jun 3, 2025

Copy link
Copy Markdown
Contributor Author

changes looks good to me. But cant they rely on store.currentTask ?

They can but it is better if we throw call backs. Gives better developer experience

rarajes2
rarajes2 approved these changes Jun 3, 2025
View reviewed changes

@rarajes2 rarajes2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkesavan13 mkesavan13 added the run_e2e Add this label to run E2E test for meeting and CC widgets label Jun 3, 2025
@mkesavan13 mkesavan13 merged commit 5d7038f into webex:ccwidgets Jun 3, 2025
22 of 23 checks passed
github-actions Bot pushed a commit that referenced this pull request Jun 3, 2025
@semantic-release-bot
chore(release): 1.28.0-ccwidgets.67 [skip ci]
dc51530 
# [1.28.0-ccwidgets.67](v1.28.0-ccwidgets.66...v1.28.0-ccwidgets.67) (2025-06-03)

### Bug Fixes

* **cc-task:** TaskList onTaskSelected callback ([#466](#466)) ([5d7038f](5d7038f))
@sreenara

sreenara commented Jun 3, 2025

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 1.28.0-ccwidgets.67 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@mkesavan13 mkesavan13 deleted the onSelectionChange branch June 4, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rsarika rsarika rsarika approved these changes
@rarajes2 rarajes2 rarajes2 approved these changes

Assignees

No one assigned

Labels

released on @ccwidgets run_e2e Add this label to run E2E test for meeting and CC widgets validated Indicates that the PR is ready for actions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mkesavan13 @sreenara @rsarika @rarajes2