Fix translations collection detection for hierarchies with mapped superclasses#90
Merged
Fix translations collection detection for hierarchies with mapped superclasses#90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes that the "translations collection" was not detected when it is defined in a mapped superclass and inherited by an entity. Due to how MappedSuperclasses work for one-to-many associations, this requires to set up the
ResolveTargetEntityListenerwith an interface to point back from the translation class to the concrete entity class.See https://github.com/doctrine/orm/blob/580a95ce3f5f016547d15ecc6cc94dd85453bed5/src/Mapping/AssociationMapping.php#L34-L57 for the meaning of the two
inheritedanddeclaredmapping entries.inheritedmeans that the field in question exists also in a parent entity class. This parent entity class is named inClassMetadata::$parentClasses, and will be inspected byPolyglotListener::getTranslationMetadatas().The previous check, which was looking at
declared, is wrong for fields declared in mapped superclasses: Mapped superclasses are not part of theparentClasseslist, and so we missed translation collections defined in those.