Conversation
mpdude
force-pushed
the
dbal4-compat
branch
2 times, most recently
from
bd7ef30 to
57d3c3c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds compatiblity with DBAL 4, while also supporting DBAL 3 for an easy transition.
The url connection parameter was removed in DBAL 4. Detect whether
Doctrine\DBAL\Tools\DsnParseris available and use it to parse the DSN into connection parameters. On DBAL 3 (withoutDsnParser) the previous['url' => ...]array is used as a fallback.DBAL 4 removed the EventManager and the
DC2Typecolumn comment mechanism along with it. TheDummyTypeRegistrationEventSubscriber— which worked around unknown custom types encoded in column comments, see Fill in dummy types to deal with DC2:... column comments #102 — is therefore no longer needed. Its is now conditional, based onclass_exists(\Doctrine\DBAL\Events::class), which is only true on DBAL 3.Connection::getSchemaManager()(deprecated in DBAL 3) was replaced withcreateSchemaManager()