Skip to content

Add WGPURequestAdapterWebXROptions.xrCompatible#508

Merged
kainino0x merged 1 commit intowebgpu-native:mainfrom
kainino0x:xrcompatible
Jan 30, 2025
Merged

Add WGPURequestAdapterWebXROptions.xrCompatible#508
kainino0x merged 1 commit intowebgpu-native:mainfrom
kainino0x:xrcompatible

Conversation

@kainino0x
Copy link
Collaborator

@kainino0x kainino0x commented Jan 29, 2025

Fixes #501

@kainino0x kainino0x requested a review from lokokung January 29, 2025 23:44
@kainino0x kainino0x added the !discuss Needs discussion (at meeting or online) label Jan 29, 2025
@kainino0x kainino0x merged commit e599246 into webgpu-native:main Jan 30, 2025
5 checks passed
@kainino0x kainino0x deleted the xrcompatible branch January 30, 2025 21:58
@kainino0x
Copy link
Collaborator Author

kainino0x commented Feb 1, 2025 •
edited
Loading

Jan 30 meeting:

  • Looks good
  • LK: Why a chain and a boolean?
  • KN: I feel like it's weird to have the presence of an extension actually do something, but no really strong feelings
  • Looks OK.

@kainino0x
Copy link
Collaborator Author

kainino0x commented Feb 1, 2025 •
edited
Loading

Oh also:

  • KN: Should compatibleSurface be moved to an extension? Is it just for WebGL?
  • CF: No, it's also used on Vulkan. And might use it in the future for GL.

@kainino0x kainino0x removed the !discuss Needs discussion (at meeting or online) label Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lokokung lokokung lokokung approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

GPURequestAdapterOptions.xrCompatible

2 participants

@kainino0x @lokokung