Autogenerate compile tests for INIT macros#581
Merged
kainino0x merged 1 commit intowebgpu-native:mainfrom Feb 20, 2026
Merged
Conversation
0c7210c to
972cbd7
Compare
Collaborator
|
Fine to have this as is for now, but it should be fairly simple to make a template + generator to do this and add a presubmit check for it as well. Otherwise, this will just get out of date when/if we add new structs. |
Collaborator
Author
|
It's regenerated by |
Collaborator
|
Ooo, sorry I didn't catch that on the first pass. Makes sense! Thanks! |
lokokung
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the manually-maintained INIT test lines with autogenerated tests. Used a quick hack in perl (only tool I could find that could do this easily), it just finds all the INIT macros defined in the header and outputs a test for each one.
It's checked into the repo (instead of generated during build) so that I don't have to deal with making it work on the Windows compile test.
This should have caught some missing items in #580