ci: drop leftover debug artifact upload from the /e2e build job - #5551
Merged
Conversation
The `build` job uploaded `.webiny/cached-packages` as a raw `build-cache` artifact - ~44k files / ~168 MB - on every /e2e run. Nothing downloads it: the only artifact any job consumes is `run-build-cache-<attempt>`, the compressed tarball added in #5548. It came from 0fb9074 ("ci: debug cache restoration [no ci]") back in May and was never cleaned up. Note the equivalent raw uploads in rebuildGlobalCache are left alone - those came from a deliberate feature commit rather than a debug commit, so somebody may be downloading them by hand. Also regenerates assignMilestone.yml, which went stale when #5542 landed: the createJob permissions baseline now adds `contents: read` and `actions: write` to every job. Harmless for that job (it neither checks out nor caches), but without this the next `yarn ci-workflows:build` would emit an unrelated diff. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The
/e2ebuildjob was uploading.webiny/cached-packagesas a rawbuild-cacheartifact — roughly 44k files / 168 MB — on every run. Nothing consumes it.Verified by enumerating every
download-artifactstep in the repository: all ten of them referencerun-build-cache-<attempt>, the compressed tarball added in #5548. No job anywhere downloadsbuild-cache.It was introduced by
0fb9074409 ci: debug cache restoration [no ci]in May and never cleaned up, so it has been costing a large upload on every/e2erun since. Removing it should shave a couple of minutes off each run.After this change the
buildjob has exactly one upload, matching/vitest,/alphaand/beta. Theverdaccio-files-*andproject-files-*uploads in the project-setup jobs are untouched — those are genuinely consumed by the Cypress jobs.The equivalent raw uploads in
rebuildGlobalCache(build-cache,yarn-cache,packages) are deliberately left alone: those came from a feature commit rather than a debug commit, so someone may be downloading them by hand for inspection.Also included
assignMilestone.ymlis regenerated. It went stale when #5542 landed — thecreateJobpermissions baseline now addscontents: readandactions: writeto every job, and that workflow's committed YAML predates it. The extra scopes are harmless there (the job neither checks out nor caches), but without this regeneration the nextyarn ci-workflows:buildwould produce an unrelated diff for whoever runs it.Changelog
Internal CI cleanup
Removed a leftover debugging step that was uploading a large file on every end-to-end test run. No user-facing change.
Squash Merge Commit