feat(website): render site footer from the root layout on every page#1082
Merged
Conversation
The footer was rendered inline only by the home page and /why, so /blog, /compare, /changelog, /articles, and every detail page had none. Move the siteFooter() call into app/layout.ts (alongside the shared header/nav chrome) and drop the per-page calls, so every route gets one footer with no duplication. Pin it with a layout SSR test that composes a bare child.
4 tasks
Each /compare card led with an amber "WebJs vs X" eyebrow, competing with the page's own amber "Compare" header for emphasis. Make the per-card eyebrow neutral (text-fg-subtle, matching the blog card's date/tag meta) so the amber accent is reserved for the single page header.
vivek7405
marked this pull request as ready for review
July 25, 2026 06:38
This was referenced Jul 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The site footer was rendered inline only by the home page and
/why, so/blog,/compare,/changelog,/articles, and every detail page shipped without one. This movessiteFooter()intoapp/layout.ts(next to the shared header/nav chrome) and drops the two per-page calls, so every route renders exactly one footer with no duplication.The user's guidance: the top navbar and footer should both be layout chrome. The navbar already was; this brings the footer in line.
Changes
app/layout.tsrenders${siteFooter()}after${children}.app/page.tsandapp/why/page.ts(no more double footer on those two).lib/site-footer.tsdocstring updated (now layout-rendered, not per-page).website/AGENTS.mdlayout note corrected (footer lives in the layout).Verification
/,/blog,/compare,/changelog,/why,/articles, and a blog detail page each render exactly one footer.webjs checkpasses,webjs typecheckclean.Closes #1083