fix: service-worker root assets (#830) + all tic-tac-toe dogfood findings (#837)#838
Merged
Conversation
added 3 commits
July 8, 2026 13:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the service-worker path bug and every finding from the tic-tac-toe dogfood session.
Closes #830
Closes #837
#830: service-worker root assets serve at the site root
A worker registered at
/sw.jsscopes to the origin root, but the scaffold servedpublic/*only at/public/*, soGET /sw.jswas a 404 and theapp/features/service-workergallery demo could never register.packages/server/src/dev.js: the shared static branch now remaps/sw.jsand/offline.htmltopublic/and addsService-Worker-Allowed: /. One place (the runtime-agnostic handler), so it covers dev, prod, Node, and Bun.packages/server/test/dev/root-assets.test.js+ a Bun parity prooftest/bun/sw-root-assets.mjs(green on node 26 AND bun 1.3.14).AGENTS.md,agent-docs/service-worker.md, the scaffoldAGENTS.md, and the gallery demo.#837: all 7 dogfood findings
{ redirect }(303 PRG); do NOT THROWredirect()from a page action (a 307 that re-POSTs and re-runs the mutation, the phantom-move bug).modules/components/components/browser/counter-card.test.jsteaches the real idioms (suite/test,ssrFixture, inline assert, no chai); the WTR glob now discovers co-located**/browser/**tests. Verified passing in real Chromium (3/3).db.queryvs coredb.select().where(eq())).sourcetool "no matches".grepSourcesno longer returns a misleading "no matches" when ZERO packages resolved (nothing was searched), and a genuine no-match now discloses the searched scope so absence is trustworthy.packages/mcp/test/mcp-source.test.mjscovers empty-roots, scope disclosure, and a cross-package (server src) find.drizzle-orm/drizzle-kitare pinned EXACTLY to1.0.0-rc.3(the tested relations-v2 API), not^, so a scaffold no longer drifts to a newer rc.npm create webjs@latest my-app(no global install) and warns that a global/shimmedwebjscan shadow the CLI.npx playwright install chromiumand thetdd-UI idioms.Verification
Generated full-stack + saas + api;
webjs checkclean (only intended placeholder markers); co-located browser test green in Chromium; #830 server tests green on Node and Bun; the 12 MCP source tests pass. No published-package version bump in this PR.https://claude.ai/code/session_01EM2Bdq3we9kmJzMw88P4q6