Fix short ternary stan errors

[shmax]

Hi guys, I'm back. I've resumed work on my lazy load PR, but I thought I'd warm up on something "easy". I went through the code base and replaced all the short ternary operators with appropriate alternatives. Let me know if I messed anything up.

[mfn]

Tests are all green, but can we be sure each and every change is technically correct? The semantics are different.

[shmax]

Tests are all green, but can we be sure each and every change is technically correct? The semantics are different.

They sure are! If you look at the changes, you'll see that I didn't just blindly replace every ?: with a ??. I tiptoed around strings in particular, and used different checks in those cases. I also carefully examined the native typehinting and PHPDoc annotations wherever they were available, and paid special attention to public methods. Whenever I was still in doubt I fired up the debugger and watched the values as they moved around. There's no guarantee I didn't miss anything (I'm going to review the changes again, myself), but as you say the tests do pass, and suffice it to say I am well aware that "the semantics are different".

[shmax]

Meanwhile, I'm not sure what's going on with the the linting. PHP_CodeSniffer evidently released a new version a few days ago (last green CI in this repo was at 3.5.4, it's now at 3.5.5), and now the linting check lit up the code base with dozens of Squiz.Arrays.ArrayDeclaration.ValueNoNewline errors, many of which are false (see squizlabs/PHP_CodeSniffer#2937)

[shmax]

Locked the code sniffer version until they issue a fix for squizlabs/PHP_CodeSniffer#2937

[simPod]

PHP_CodeSniffer evidently released a new version a few days ago (last green CI in this repo was at 3.5.4, it's now at 3.5.5), and now the linting check lit up the code base with dozens of Squiz.Arrays.ArrayDeclaration.ValueNoNewline errors, many of which are false

I went ahead and pushed this a2780a0 to avoid pollution in PRs

[shmax]

I went ahead and pushed this a2780a0 to avoid pollution in PRs

Ah, very helpful, thanks. I'll update my PRs in the morning. 👍

[shmax]

@simPod Is there anything I still need to do on this PR?

[coveralls]

Coverage increased (+0.001%) to 86.13% when pulling 372eecd on shmax:fix-short-ternary into 1f0ec24 on webonyx:master.

[simPod]

@shmax I'll try to contact @vladar and ask if I can go forward with such PRs myself

[shmax]

That would be lovely, thank you.

[vladar]

Looks good to me, thanks!

Also, sorry for the lack of activity, I've been super busy recently. Looking forward to work on graphql-php as soon as I finish my current project at work.

[shmax]

No problem, been rather crushed, myself.

Thank you both for reviewing!