Skip to content

Fix short ternary stan errors #645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vladar merged 22 commits into from
May 19, 2020
Merged

Fix short ternary stan errors #645

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
25d919e
elvis has left the building
shmax Apr 18, 2020
2d7577f
restore param
shmax Apr 18, 2020
4d07318
fix param
shmax Apr 18, 2020
a621585
conservative string handling
shmax Apr 18, 2020
76254bc
lock sniffer
shmax Apr 18, 2020
923ef32
lint
shmax Apr 18, 2020
226b018
update stan, invert ternary
shmax Apr 19, 2020
f7fea78
update baseline command
shmax Apr 19, 2020
9e8a6b2
regenerate baseline
shmax Apr 19, 2020
393c555
reverse ternary, add check
shmax Apr 19, 2020
4a6ffb4
reverse ternary, add check
shmax Apr 19, 2020
1b3e4ce
Update tests/Executor/DirectivesTest.php
shmax Apr 19, 2020
477371d
remove method
shmax Apr 19, 2020
6665dfb
Merge branch 'fix-short-ternary' of https://github.com/shmax/graphql-…
shmax Apr 19, 2020
05fec8a
update stan
shmax Apr 19, 2020
f71d259
try again
shmax Apr 19, 2020
34036a4
remove typehint
shmax Apr 20, 2020
d873515
use default baseline filename
shmax Apr 20, 2020
3a57ce5
fix new error
shmax Apr 20, 2020
cd923fc
Merge branch 'master' into fix-short-ternary
shmax Apr 27, 2020
7ece24d
Merge branch 'master' into fix-short-ternary
shmax Apr 28, 2020
372eecd
Merge branch 'master' into fix-short-ternary
shmax May 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
"lint" : "phpcs",
"fix" : "phpcbf",
"stan": "phpstan analyse --ansi --memory-limit 2048M",
"phpstan-baseline": "phpstan analyse --ansi --generate-baseline=phpstan-baseline.neon",
"phpstan-baseline": "phpstan analyse --ansi --generate-baseline",
"check": "composer lint && composer stan && composer test"
}
}
177 changes: 1 addition & 176 deletions phpstan-baseline.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,6 @@ parameters:
count: 1
path: src/Error/Error.php

-
message: "#^Short ternary operator is not allowed\\. Use null coalesce operator if applicable or consider using long ternary\\.$#"
count: 6
path: src/Error/Error.php

-
message: "#^Only booleans are allowed in &&, Throwable\\|null given on the left side\\.$#"
count: 1
Expand Down Expand Up @@ -80,11 +75,6 @@ parameters:
count: 1
path: src/Error/FormattedError.php

-
message: "#^Short ternary operator is not allowed\\. Use null coalesce operator if applicable or consider using long ternary\\.$#"
count: 3
path: src/Error/FormattedError.php

-
message: "#^Construct empty\\(\\) is not allowed\\. Use more strict comparison\\.$#"
count: 5
Expand All @@ -110,46 +100,16 @@ parameters:
count: 1
path: src/Error/FormattedError.php

-
message: "#^Short ternary operator is not allowed\\. Use null coalesce operator if applicable or consider using long ternary\\.$#"
count: 2
path: src/Error/Warning.php

-
message: "#^Short ternary operator is not allowed\\. Use null coalesce operator if applicable or consider using long ternary\\.$#"
count: 1
path: src/Executor/ExecutionContext.php

-
message: "#^Construct empty\\(\\) is not allowed\\. Use more strict comparison\\.$#"
count: 2
path: src/Executor/ExecutionResult.php

-
message: "#^Short ternary operator is not allowed\\. Use null coalesce operator if applicable or consider using long ternary\\.$#"
count: 1
path: src/Executor/ExecutionResult.php

-
message: "#^Short ternary operator is not allowed\\. Use null coalesce operator if applicable or consider using long ternary\\.$#"
count: 2
path: src/Executor/Executor.php

-
message: "#^Variable property access on object\\.$#"
count: 2
path: src/Executor/Executor.php

-
message: "#^Short ternary operator is not allowed\\. Use null coalesce operator if applicable or consider using long ternary\\.$#"
count: 1
path: src/Executor/Promise/Adapter/SyncPromise.php

-
message: "#^Short ternary operator is not allowed\\. Use null coalesce operator if applicable or consider using long ternary\\.$#"
count: 5
path: src/Executor/ReferenceExecutor.php

-
message: "#^Construct empty\\(\\) is not allowed\\. Use more strict comparison\\.$#"
count: 4
Expand Down Expand Up @@ -185,11 +145,6 @@ parameters:
count: 3
path: src/Experimental/Executor/CoroutineExecutor.php

-
message: "#^Short ternary operator is not allowed\\. Use null coalesce operator if applicable or consider using long ternary\\.$#"
count: 2
path: src/Experimental/Executor/CoroutineExecutor.php

-
message: "#^Variable property access on object\\.$#"
count: 2
Expand All @@ -200,11 +155,6 @@ parameters:
count: 1
path: src/Experimental/Executor/CoroutineExecutor.php

-
message: "#^Short ternary operator is not allowed\\. Use null coalesce operator if applicable or consider using long ternary\\.$#"
count: 1
path: src/GraphQL.php

-
message: "#^Construct empty\\(\\) is not allowed\\. Use more strict comparison\\.$#"
count: 2
Expand All @@ -220,41 +170,16 @@ parameters:
count: 1
path: src/Language/AST/Node.php

-
message: "#^Short ternary operator is not allowed\\. Use null coalesce operator if applicable or consider using long ternary\\.$#"
count: 2
path: src/Language/Lexer.php

-
message: "#^Construct empty\\(\\) is not allowed\\. Use more strict comparison\\.$#"
count: 3
path: src/Language/Parser.php

-
message: "#^Short ternary operator is not allowed\\. Use null coalesce operator if applicable or consider using long ternary\\.$#"
count: 1
path: src/Language/Parser.php

-
message: "#^Short ternary operator is not allowed\\. Use null coalesce operator if applicable or consider using long ternary\\.$#"
count: 1
path: src/Language/Printer.php

-
message: "#^Only booleans are allowed in a ternary operator condition, array\\<GraphQL\\\\Language\\\\AST\\\\NamedTypeNode\\>\\|null given\\.$#"
count: 2
path: src/Language/Printer.php

-
message: "#^Short ternary operator is not allowed\\. Use null coalesce operator if applicable or consider using long ternary\\.$#"
count: 2
path: src/Language/Source.php

-
message: "#^Short ternary operator is not allowed\\. Use null coalesce operator if applicable or consider using long ternary\\.$#"
count: 2
path: src/Language/Visitor.php

-
message: "#^Only booleans are allowed in a negated boolean, array\\<int, array\\|GraphQL\\\\Language\\\\AST\\\\Node\\|GraphQL\\\\Language\\\\AST\\\\NodeList\\> given\\.$#"
count: 1
Expand Down Expand Up @@ -295,11 +220,6 @@ parameters:
count: 2
path: src/Server/Helper.php

-
message: "#^Short ternary operator is not allowed\\. Use null coalesce operator if applicable or consider using long ternary\\.$#"
count: 4
path: src/Server/Helper.php

-
message: "#^Only booleans are allowed in an if condition, int given\\.$#"
count: 1
Expand Down Expand Up @@ -340,11 +260,6 @@ parameters:
count: 1
path: src/Server/Helper.php

-
message: "#^Short ternary operator is not allowed\\. Use null coalesce operator if applicable or consider using long ternary\\.$#"
count: 2
path: src/Server/OperationParams.php

-
message: "#^Construct empty\\(\\) is not allowed\\. Use more strict comparison\\.$#"
count: 2
Expand All @@ -360,11 +275,6 @@ parameters:
count: 1
path: src/Type/Definition/EnumType.php

-
message: "#^Short ternary operator is not allowed\\. Use null coalesce operator if applicable or consider using long ternary\\.$#"
count: 1
path: src/Type/Definition/FieldDefinition.php

-
message: "#^Variable property access on \\$this\\(GraphQL\\\\Type\\\\Definition\\\\InputObjectField\\)\\.$#"
count: 1
Expand All @@ -380,11 +290,6 @@ parameters:
count: 1
path: src/Type/Definition/InputObjectType.php

-
message: "#^Short ternary operator is not allowed\\. Use null coalesce operator if applicable or consider using long ternary\\.$#"
count: 1
path: src/Type/Definition/ObjectType.php

-
message: "#^Only booleans are allowed in a negated boolean, GraphQL\\\\Language\\\\AST\\\\SelectionSetNode\\|null given\\.$#"
count: 1
Expand Down Expand Up @@ -416,7 +321,7 @@ parameters:
path: src/Type/Introspection.php

-
message: "#^Short ternary operator is not allowed\\. Use null coalesce operator if applicable or consider using long ternary\\.$#"
message: "#^Anonymous function should have native return typehint \"array\"\\.$#"
count: 1
path: src/Type/Introspection.php

Expand All @@ -430,11 +335,6 @@ parameters:
count: 1
path: src/Type/Schema.php

-
message: "#^Short ternary operator is not allowed\\. Use null coalesce operator if applicable or consider using long ternary\\.$#"
count: 1
path: src/Type/Schema.php

-
message: "#^Only booleans are allowed in a negated boolean, GraphQL\\\\Type\\\\Definition\\\\Type\\|null given\\.$#"
count: 1
Expand Down Expand Up @@ -515,11 +415,6 @@ parameters:
count: 1
path: src/Type/SchemaValidationContext.php

-
message: "#^Short ternary operator is not allowed\\. Use null coalesce operator if applicable or consider using long ternary\\.$#"
count: 1
path: src/Type/SchemaValidationContext.php

-
message: "#^Only booleans are allowed in a negated boolean, GraphQL\\\\Language\\\\AST\\\\InterfaceTypeDefinitionNode\\|GraphQL\\\\Language\\\\AST\\\\InterfaceTypeExtensionNode\\|GraphQL\\\\Language\\\\AST\\\\ObjectTypeDefinitionNode\\|GraphQL\\\\Language\\\\AST\\\\ObjectTypeExtensionNode given\\.$#"
count: 1
Expand Down Expand Up @@ -660,11 +555,6 @@ parameters:
count: 1
path: src/Utils/ASTDefinitionBuilder.php

-
message: "#^Short ternary operator is not allowed\\. Use null coalesce operator if applicable or consider using long ternary\\.$#"
count: 1
path: src/Utils/BreakingChangesFinder.php

-
message: "#^Construct empty\\(\\) is not allowed\\. Use more strict comparison\\.$#"
count: 3
Expand Down Expand Up @@ -725,11 +615,6 @@ parameters:
count: 1
path: src/Utils/TypeInfo.php

-
message: "#^Short ternary operator is not allowed\\. Use null coalesce operator if applicable or consider using long ternary\\.$#"
count: 1
path: src/Utils/TypeInfo.php

-
message: "#^Only booleans are allowed in an if condition, GraphQL\\\\Type\\\\Definition\\\\Directive\\|GraphQL\\\\Type\\\\Definition\\\\FieldDefinition\\|null given\\.$#"
count: 1
Expand All @@ -750,11 +635,6 @@ parameters:
count: 1
path: src/Utils/TypeInfo.php

-
message: "#^Short ternary operator is not allowed\\. Use null coalesce operator if applicable or consider using long ternary\\.$#"
count: 1
path: src/Utils/Utils.php

-
message: "#^Variable property access on object\\.$#"
count: 1
Expand Down Expand Up @@ -795,11 +675,6 @@ parameters:
count: 1
path: src/Utils/Value.php

-
message: "#^Short ternary operator is not allowed\\. Use null coalesce operator if applicable or consider using long ternary\\.$#"
count: 1
path: src/Validator/DocumentValidator.php

-
message: "#^Only booleans are allowed in a negated boolean, \\(GraphQL\\\\Type\\\\Definition\\\\CompositeType&GraphQL\\\\Type\\\\Definition\\\\Type\\)\\|null given\\.$#"
count: 1
Expand Down Expand Up @@ -905,11 +780,6 @@ parameters:
count: 2
path: src/Validator/Rules/OverlappingFieldsCanBeMerged.php

-
message: "#^Short ternary operator is not allowed\\. Use null coalesce operator if applicable or consider using long ternary\\.$#"
count: 2
path: src/Validator/Rules/OverlappingFieldsCanBeMerged.php

-
message: "#^Only booleans are allowed in a negated boolean, GraphQL\\\\Language\\\\AST\\\\ArgumentNode\\|null given\\.$#"
count: 1
Expand Down Expand Up @@ -940,11 +810,6 @@ parameters:
count: 1
path: src/Validator/Rules/ProvidedRequiredArguments.php

-
message: "#^Short ternary operator is not allowed\\. Use null coalesce operator if applicable or consider using long ternary\\.$#"
count: 2
path: src/Validator/Rules/ProvidedRequiredArguments.php

-
message: "#^Only booleans are allowed in \\|\\|, GraphQL\\\\Language\\\\AST\\\\ArgumentNode\\|null given on the left side\\.$#"
count: 1
Expand All @@ -970,26 +835,11 @@ parameters:
count: 1
path: src/Validator/Rules/ProvidedRequiredArgumentsOnDirectives.php

-
message: "#^Short ternary operator is not allowed\\. Use null coalesce operator if applicable or consider using long ternary\\.$#"
count: 1
path: src/Validator/Rules/ProvidedRequiredArgumentsOnDirectives.php

-
message: "#^Construct empty\\(\\) is not allowed\\. Use more strict comparison\\.$#"
count: 3
path: src/Validator/Rules/QueryComplexity.php

-
message: "#^Short ternary operator is not allowed\\. Use null coalesce operator if applicable or consider using long ternary\\.$#"
count: 1
path: src/Validator/Rules/QueryComplexity.php

-
message: "#^Short ternary operator is not allowed\\. Use null coalesce operator if applicable or consider using long ternary\\.$#"
count: 2
path: src/Validator/Rules/QuerySecurityRule.php

-
message: "#^Only booleans are allowed in &&, GraphQL\\\\Type\\\\Definition\\\\Type\\|null given on the left side\\.$#"
count: 1
Expand Down Expand Up @@ -1050,11 +900,6 @@ parameters:
count: 1
path: src/Validator/Rules/UniqueVariableNames.php

-
message: "#^Short ternary operator is not allowed\\. Use null coalesce operator if applicable or consider using long ternary\\.$#"
count: 1
path: src/Validator/Rules/ValidationRule.php

-
message: "#^Only booleans are allowed in \\|\\|, GraphQL\\\\Type\\\\Definition\\\\EnumType\\|GraphQL\\\\Type\\\\Definition\\\\InputObjectType\\|GraphQL\\\\Type\\\\Definition\\\\ListOfType\\|GraphQL\\\\Type\\\\Definition\\\\NonNull\\|GraphQL\\\\Type\\\\Definition\\\\ScalarType given on the left side\\.$#"
count: 1
Expand Down Expand Up @@ -1115,16 +960,6 @@ parameters:
count: 1
path: tests/Executor/DirectivesTest.php

-
message: "#^Short ternary operator is not allowed\\. Use null coalesce operator if applicable or consider using long ternary\\.$#"
count: 1
path: tests/Executor/DirectivesTest.php

-
message: "#^Short ternary operator is not allowed\\. Use null coalesce operator if applicable or consider using long ternary\\.$#"
count: 7
path: tests/Executor/ExecutorLazySchemaTest.php

-
message: "#^Only booleans are allowed in a negated boolean, GraphQL\\\\Type\\\\Definition\\\\InterfaceType given\\.$#"
count: 1
Expand Down Expand Up @@ -1165,11 +1000,6 @@ parameters:
count: 4
path: tests/Language/VisitorTest.php

-
message: "#^Short ternary operator is not allowed\\. Use null coalesce operator if applicable or consider using long ternary\\.$#"
count: 1
path: tests/Server/Psr7/PsrStreamStub.php

-
message: "#^Construct empty\\(\\) is not allowed\\. Use more strict comparison\\.$#"
count: 1
Expand Down Expand Up @@ -1200,8 +1030,3 @@ parameters:
count: 2
path: tests/Utils/MixedStoreTest.php

-
message: "#^Short ternary operator is not allowed\\. Use null coalesce operator if applicable or consider using long ternary\\.$#"
count: 1
path: tests/Utils/ValueFromAstTest.php

Loading