Fold long undefined-symbol reports with <details>/<summary>#6
Merged
Merged
Conversation
The --details Markdown report of ipk-verify lists every undefined symbol of a failing native binary as a bullet, which can run to dozens or hundreds of entries and make the report unwieldy in CI/PR comments. Collapse the undefined-symbol list into a <details>/<summary> block when it has more than 10 entries, and only for Markdown output. Terminal and Plain output keep the plain bullet list, where raw HTML tags would just be noise. Missing-library bullets stay inline. To do this, thread the OutputFormat through print_component_details into print_bin_verify_details. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PfjeD1nBEtfapZGVJ1U9am
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The --details Markdown report of ipk-verify lists every undefined symbol
of a failing native binary as a bullet, which can run to dozens or
hundreds of entries and make the report unwieldy in CI/PR comments.
Collapse the undefined-symbol list into a
block when
it has more than 10 entries, and only for Markdown output. Terminal and
Plain output keep the plain bullet list, where raw HTML tags would just
be noise. Missing-library bullets stay inline. To do this, thread the
OutputFormat through print_component_details into print_bin_verify_details.
Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01PfjeD1nBEtfapZGVJ1U9am