Skip to content

add taps type to hook class#161

Merged
sokra merged 1 commit intowebpack:masterfrom
chengcyber:feat-hook-type
Sep 13, 2021
Merged

add taps type to hook class#161
sokra merged 1 commit intowebpack:masterfrom
chengcyber:feat-hook-type

Conversation

@chengcyber
Copy link
Copy Markdown
Contributor

Summary

Add taps type to hook class, make the following code works

const appliedPluginNames: Set<string> = new Set<string>(pluginHook.taps.map(x => x.name));

which also fixes #152

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented Sep 10, 2021

CLA Signed

The committers are authorized under a signed CLA.

@sokra sokra merged commit 5ce6d8c into webpack:master Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

has hooks.hookName.taps been not recommanded?

3 participants