Skip to content

refactor: move zero-config from group design#1820

Merged
rishabh3112 merged 6 commits intowebpack:nextfrom
anshumanv:ref/zero-group
Sep 23, 2020
Merged

refactor: move zero-config from group design#1820
rishabh3112 merged 6 commits intowebpack:nextfrom
anshumanv:ref/zero-group

Conversation

@anshumanv
Copy link
Copy Markdown
Member

What kind of change does this PR introduce?

refactor

Did you add tests for your changes?
Changed

If relevant, did you update the documentation?
NA

Summary

  • Refactor zero config group to pure fn, remove it from group design

Does this PR introduce a breaking change?
No

Other information

Comment thread packages/webpack-cli/lib/groups/resolveMode.js
@anshumanv anshumanv marked this pull request as ready for review September 22, 2020 16:22
@anshumanv anshumanv requested a review from a team as a code owner September 22, 2020 16:22
@webpack-bot
Copy link
Copy Markdown

@anshumanv Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@evilebottnawi Please review the new changes.

@anshumanv
Copy link
Copy Markdown
Member Author

/cc @webpack/cli-team can anyone review?

@rishabh3112 rishabh3112 merged commit 134c77a into webpack:next Sep 23, 2020
@anshumanv anshumanv deleted the ref/zero-group branch September 23, 2020 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants