chore: make prettier peer dependency meta#1829
Merged
alexander-akait merged 5 commits intonextfrom Sep 24, 2020
Merged
Conversation
Member
Author
Will do before merging. |
alexander-akait
requested changes
Sep 24, 2020
Member
alexander-akait
left a comment
alexander-akait
left a comment
There was a problem hiding this comment.
Also please update lock file
|
@rishabh3112 Thanks for your update. I labeled the Pull Request so reviewers will review it again. @evilebottnawi Please review the new changes. |
webpack-bot
added
PR: review-outdated
and removed
PR: reviewed-changes-requested
labels
anshumanv
reviewed
Sep 24, 2020
alexander-akait
previously approved these changes
Sep 24, 2020
anshumanv
reviewed
Sep 24, 2020
anshumanv
approved these changes
Sep 24, 2020
alexander-akait
approved these changes
Sep 24, 2020
jamesgeorge007
approved these changes
Sep 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
chore
Did you add tests for your changes?
No
If relevant, did you update the documentation?
No
Summary
Make prettier a peer dep meta as prettier is generally available to the user.
Does this PR introduce a breaking change?
People will now have to install prettier on there own to use init
Other information
Based of recent feedbacks