Conversation
| if (outputOptions.json) { | ||
| process.stdout.write(JSON.stringify(stats.toJson(outputOptions), null, 2) + '\n'); | ||
| if (outputOptions.json === true) { | ||
| logger.raw(JSON.stringify(stats.toJson(outputOptions), null, 2)); |
Member
There was a problem hiding this comment.
It should be process.stdout.write
snitin315
force-pushed
the
feat/json
branch
from
41e05cd to
46d0344
Compare
snitin315
force-pushed
the
feat/json
branch
from
46d0344 to
b4a2406
Compare
ylemkimon
reviewed
Sep 28, 2020
| statsErrors.push({ name: statErr.message, loc: errLoc }); | ||
| }); | ||
| } | ||
| const JSONStats = JSON.stringify(stats.toJson(outputOptions), null, 2); |
Contributor
There was a problem hiding this comment.
Note JSON.stringify doesn't end with a newline.
Member
|
/cc @webpack/cli-team |
evenstensberg
previously approved these changes
Sep 29, 2020
rishabh3112
requested changes
Sep 30, 2020
snitin315
force-pushed
the
feat/json
branch
from
8b5d295 to
fc7cb3d
Compare
webpack-bot
added
PR: review-outdated
and removed
PR: reviewed-approved
PR: reviewed-changes-requested
labels
anshumanv
reviewed
Sep 30, 2020
| -d, --devtool string Controls if and how source maps are generated. | ||
| --prefetch string Prefetch this request | ||
| -j, --json Prints result as JSON | ||
| -j, --json string Prints result as JSON or store it in a file |
Member
There was a problem hiding this comment.
should be string, boolean right?
snitin315
force-pushed
the
feat/json
branch
from
2803c89 to
bfd480b
Compare
snitin315
force-pushed
the
feat/json
branch
from
bfd480b to
fadb077
Compare
alexander-akait
approved these changes
Oct 2, 2020
Member
|
I think we can improve docs and replace this out of box https://github.com/FormidableLabs/webpack-stats-plugin |
anshumanv
approved these changes
Oct 3, 2020
|
@snitin315 Thanks for your update. I labeled the Pull Request so reviewers will review it again. @anshumanv Please review the new changes. |
rishabh3112
approved these changes
Oct 3, 2020
jamesgeorge007
approved these changes
Oct 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
feature
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
Summary
Fixes #1535
Does this PR introduce a breaking change?
No
Other information