Skip to content

Conversation

@tw4l
Copy link
Member

@tw4l tw4l commented Nov 25, 2025

Backend implementation for #3010

I've kept the endpoint as /search-values to be consistent with our other search values endpoints. This is inconsistent with our other profile endpoints' casing, so could go the other way if anyone has strong opinions. Something to address when we have a v2 API.

@tw4l tw4l requested review from SuaYoo and ikreymer November 25, 2025 21:46
@SuaYoo
Copy link
Member

SuaYoo commented Nov 26, 2025

Search endpoint is working well, it looks like we need a corresponding name filter for profiles.

@ikreymer
Copy link
Member

Search endpoint is working well, it looks like we need a corresponding name filter for profiles.

Added filtering by name

Copy link
Member

@SuaYoo SuaYoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, tested with #3017

@ikreymer ikreymer merged commit 6febd22 into main Nov 26, 2025
25 of 30 checks passed
@ikreymer ikreymer deleted the issue-3010-browser-profile-search-backend branch November 26, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants