-
-
Notifications
You must be signed in to change notification settings - Fork 60
feat: Filter browser profile list by name #3017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Filter browser profile list by name #3017
Conversation
12f5cc7 to
88a3a18
Compare
|
FYI @emma-sg I tried combining the list filters into a single |
emma-sg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like it's missing a way to clear the search, both within the search box & in the filter bar (setting a search value doesn't show the "clear all" button).
I'm not able to replicate the X button not appearing in the search box, could you provide more details? |
095ca3e to
26cc3f7
Compare
emma-sg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more bug here with hasFiltersSet, but other than that looks good!
Co-authored-by: Emma Segal-Grossman <hi@emma.cafe>
emma-sg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
tw4l
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Tested locally (rebased against main for backend changes) and everything is working as expected.
8ada243
into
frontend-browser-profile-ui-enhancements
Depends on #3015
WIP for #3010
Changes
Manual testing
Backend must point to latest in #3015
Screenshots