Skip to content

Conversation

@SuaYoo
Copy link
Member

@SuaYoo SuaYoo commented Nov 26, 2025

Depends on #3015
WIP for #3010

Changes

  • Allows users to filter browser profile list by name
  • Fixes layout inconsistencies with browser profiles list

Manual testing

Backend must point to latest in #3015

  1. Log in
  2. Go to "Browser Profiles"
  3. Enter text into search box. Verify search results are shown
  4. Choose search research. Verify profile list is filtered
  5. Reload page. Verify search term persists

Screenshots

Page Image/video
Browser Profiles Screenshot 2025-11-26 at 7 56 55 AM

@SuaYoo SuaYoo force-pushed the frontend-browser-profile-ui-enhancements--search branch from 12f5cc7 to 88a3a18 Compare November 26, 2025 01:57
@SuaYoo SuaYoo changed the title WIP: Filter browser profile list by name feat: Filter browser profile list by name Nov 26, 2025
@SuaYoo
Copy link
Member Author

SuaYoo commented Nov 26, 2025

FYI @emma-sg I tried combining the list filters into a single filterBy here, it seems to work well so may be a pattern we want to consider for the other list controls.

@SuaYoo SuaYoo requested review from emma-sg, ikreymer and tw4l November 26, 2025 16:07
@SuaYoo SuaYoo marked this pull request as ready for review November 26, 2025 16:07
Copy link
Member

@emma-sg emma-sg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it's missing a way to clear the search, both within the search box & in the filter bar (setting a search value doesn't show the "clear all" button).

@SuaYoo
Copy link
Member Author

SuaYoo commented Nov 26, 2025

This looks like it's missing a way to clear the search, both within the search box & in the filter bar (setting a search value doesn't show the "clear all" button).

I'm not able to replicate the X button not appearing in the search box, could you provide more details?

@SuaYoo SuaYoo force-pushed the frontend-browser-profile-ui-enhancements--search branch from 095ca3e to 26cc3f7 Compare November 26, 2025 21:40
@SuaYoo SuaYoo requested a review from emma-sg November 26, 2025 22:27
Copy link
Member

@emma-sg emma-sg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more bug here with hasFiltersSet, but other than that looks good!

Co-authored-by: Emma Segal-Grossman <hi@emma.cafe>
@SuaYoo SuaYoo requested a review from emma-sg November 27, 2025 02:03
Copy link
Member

@emma-sg emma-sg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Member

@tw4l tw4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Tested locally (rebased against main for backend changes) and everything is working as expected.

@SuaYoo SuaYoo merged commit 8ada243 into frontend-browser-profile-ui-enhancements Nov 27, 2025
37 of 40 checks passed
@SuaYoo SuaYoo deleted the frontend-browser-profile-ui-enhancements--search branch November 27, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants