fix: Prevent using disabled proxy from crawling defaults#3329
Merged
Conversation
emma-sg
approved these changes
May 22, 2026
Member
tw4l
approved these changes
May 25, 2026
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3278
Changes
Manual testing
us-proxy-2on an orgus-proxy-2as default from org settingsus-proxy-2from org from superadmin dashboardus-proxy-2is not selectedFollow-ups
This change doesn't actually remove the disabled proxy from crawling defaults, just checks if the proxy ID specified as a crawling default exists in the org proxy server list. We may want to update the backend to remove the proxy from crawling defaults when it's disabled by a superadmin (cc @tw4l.)