Skip to content

fix: Prevent using disabled proxy from crawling defaults#3329

Merged
SuaYoo merged 2 commits into
mainfrom
frontend-fix-default-proxy
May 25, 2026
Merged

fix: Prevent using disabled proxy from crawling defaults#3329
SuaYoo merged 2 commits into
mainfrom
frontend-fix-default-proxy

Conversation

@SuaYoo

@SuaYoo SuaYoo commented May 22, 2026

Copy link
Copy Markdown
Member

Resolves #3278

Changes

  • Fixes edge case where a proxy that is no longer enabled from an org is used.
  • Fixes incorrect value passed for default proxy ID.

Manual testing

  1. Log in as superadmin
  2. Enable us-proxy-2 on an org
  3. Go to org settings
  4. Set us-proxy-2 as default from org settings
  5. Go to superadmin dashboard
  6. Remove us-proxy-2 from org from superadmin dashboard
  7. Go to org dashboard
  8. Go to New Browser Profile > Start Browser. Verify that us-proxy-2 is not selected

Follow-ups

This change doesn't actually remove the disabled proxy from crawling defaults, just checks if the proxy ID specified as a crawling default exists in the org proxy server list. We may want to update the backend to remove the proxy from crawling defaults when it's disabled by a superadmin (cc @tw4l.)

@SuaYoo
SuaYoo requested review from emma-sg, ikreymer and tw4l May 22, 2026 00:45
@tw4l

tw4l commented May 25, 2026

Copy link
Copy Markdown
Member

@SuaYoo @emma-sg Hope you don't mind, since it was a quick addition I added a backend commit so we can just wrap this up here and not require a follow-up :) I've tested locally to ensure it works when both individual and shared proxies are removed from an org.

@SuaYoo

SuaYoo commented May 25, 2026

Copy link
Copy Markdown
Member Author

@SuaYoo @emma-sg Hope you don't mind, since it was a quick addition I added a backend commit so we can just wrap this up here and not require a follow-up :) I've tested locally to ensure it works when both individual and shared proxies are removed from an org.

Manually tested on dev, looks good!

@SuaYoo
SuaYoo merged commit e823c13 into main May 25, 2026
30 checks passed
@SuaYoo
SuaYoo deleted the frontend-fix-default-proxy branch May 25, 2026 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Org default proxy not reset after disabling proxy

3 participants