fix(hash): correct random() length handling and harden helpers#102
Merged
benkhalife merged 2 commits intoJun 16, 2026
Conversation
random() returned at most a hash digest's worth of hex and threw a TypeError on odd lengths under strict types. Rewrite it to emit exactly the requested number of hex characters from random_bytes() for any positive length, drop the unused algorithm parameter, and reject non-positive lengths. Reduce token() to a wrapper over random(). Reimplement salted() with HMAC to remove length-extension and salt/data boundary weaknesses, and document md5()/sha1() as checksum-only. BREAKING CHANGE: Hash::random() no longer accepts an algorithm argument.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
random() returned at most a hash digest's worth of hex and threw a TypeError on odd lengths under strict types. Rewrite it to emit exactly the requested number of hex characters from random_bytes() for any positive length, drop the unused algorithm parameter, and reject non-positive lengths. Reduce token() to a wrapper over random().
Reimplement salted() with HMAC to remove length-extension and salt/data boundary weaknesses, and document md5()/sha1() as checksum-only.
BREAKING CHANGE: Hash::random() no longer accepts an algorithm argument.