fix(session): secure cookie defaults and session-fixation hardening#103
Merged
benkhalife merged 2 commits intoJun 16, 2026
Merged
Conversation
Default session cookies to HttpOnly and SameSite=Lax, and set the Secure flag automatically when the request is over HTTPS. Validate the session ID and reject setting it after the session has started, and preserve cookie attributes when clearing the cookie on destroy. Make setLifetime() warn and return false when called too late instead of failing silently, and fix has()/forget() to use array_key_exists so null-valued keys are detected and removable. Add optional bind() and verifyFingerprint() for User-Agent session binding. BREAKING CHANGE: Session::setCookieParams() and Session::setLifetime() change signatures and now return values.
…-fixation-hardening
benkhalife
deleted the
session-secure-cookie-defaults-and-session-fixation-hardening
branch
June 21, 2026 12:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Default session cookies to HttpOnly and SameSite=Lax, and set the Secure flag automatically when the request is over HTTPS. Validate the session ID and reject setting it after the session has started, and preserve cookie attributes when clearing the cookie on destroy.
Make setLifetime() warn and return false when called too late instead of failing silently, and fix has()/forget() to use array_key_exists so null-valued keys are detected and removable. Add optional bind() and verifyFingerprint() for User-Agent session binding.
BREAKING CHANGE: Session::setCookieParams() and Session::setLifetime() change signatures and now return values.