Feature/secure upload and helper#109
Merged
Merged
Conversation
…ME data Hand-curated extension→MIME map, dangerous-extension blacklist, and category groupings (image, video, audio, pdf, document, archive) shared by Upload and UploadHelper.
…sanitization Add an extension↔MIME consistency check (anti-spoofing), a dangerous-extension blacklist with explicit opt-out, an empty-file guard, and stronger filename sanitization (null bytes, control chars, leading/trailing dots, double-extension collapse). Extract the upload check into a protected isUploadedFile() seam for testability without changing production behaviour.
…ad types Pre-configured Upload instances per category (image, video, audio, pdf, document, archive) with sensible size caps and security flags on by default. SVG is excluded from image(). All defaults remain overridable via the fluent API.
Cover construction, metadata, validation, size/extension/MIME rules, the dangerous-extension blacklist, anti-spoofing consistency checks, and filename sanitization. Uses a local UploadStub that overrides only isUploadedFile().
Verify each factory wires the correct extension list, default size cap, and security flags, that SVG is excluded from images, and that defaults stay overridable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.