Fix/session flash key collision#121
Merged
Merged
Conversation
…n with Flash Session::flash()/getFlash() used the literal key '_flash_old' to track its own flash-aging state, colliding with Flash::withInput()'s use of the same key and silently wiping old input on the next request.
Replaces the removed Session::flash()/getFlash(). Uses a namespaced
session key (_flash_data_{key}) so it can never collide with other
Flash data or plain Session keys.
… key collision Regression test reproduces the original bug: Flash::withInput() followed by a Session::start() on the "next request" used to wipe the stored input before old() could read it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.