Add bundled default english validation messages#90
Merged
benkhalife merged 3 commits intoJun 15, 2026
Conversation
- loadMessages() no longer throws when langs/{locale}/validation.php
is missing in the consuming application.
- Add resolution order: app translation file -> package default for
active locale -> package default for "en".
- Add DEFAULT_MESSAGES_PATH constant pointing to resources/lang
inside the package.
- Fix validateBetween() to return a nested ['between', type]
messageKey, consistent with min/max, so translations resolve
correctly for string/numeric/array values.
- Update constructor docblock to drop the obsolete @throws tag.
Fixed #88
- Cover all validation rules (required, string, alpha, alpha_num, numeric, integer, boolean, digits, digits_between, different, confirmed, min, max, between, email, phone, url, domain, mac, ip, array, object, regex, in, not_in, json, date). - Cover nullable() and sometimes() field modifiers. - Cover validate(), isValid(), fails(), passes(), getErrors(), getFirstError(), getFirstErrorMessage(). - Cover custom messages, :attribute label substitution, and default messages resolved from the package's bundled resources/lang/en/validation.php. - Cover ReDoS pattern rejection in regex() and value trimming/sanitization in getValue(). Close #89
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.