This repository was archived by the owner on Aug 23, 2022. It is now read-only.
Improve cancel saftety of RTP interceptors #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5 +/- ##
===========================================
- Coverage 59.81% 30.81% -29.00%
===========================================
Files 32 32
Lines 2013 4524 +2511
Branches 575 1180 +605
===========================================
+ Hits 1204 1394 +190
- Misses 250 2571 +2321
Partials 559 559
Continue to review full report at Codecov.
|
This makes the following methods cancel safe: * `report::receiver::receiver_stream::Receiverstream::read` * `nack::generator::generator_stream::GeneratorStream::read` This was achieved mostly by making locks(`tokio::Mutex`) that were async not be. Since none of these locks are held across `.await` points there's no need for them to be async locks.
k0nserv
force-pushed
the
fix/de-async-time-gen
branch
from
7c37dc9 to
6e1af04
Compare
k0nserv
changed the title
14 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the timegen code was async because it used an async
lock(
tokio::sync::Mutex). However, there's no need to use such a lockand doing so makes it more complex to achieve cancel safety elsewhere.