Skip to content

Conversation

@k0nserv
Copy link
Member

@k0nserv k0nserv commented Aug 24, 2022

A previous fix for this issue has proven not to work. With this we
make time entirely deterministic in this test, a practice that we should
use in other tests if successful here.

A [previous fix][0] for this issue has proven not to work. With this we
make time entirely deterministic in this test, a practice that we should
use in other tests if successful here.

[0]: webrtc-rs/interceptor@0a2e942
@k0nserv
Copy link
Member Author

k0nserv commented Aug 24, 2022

I initially introduced this problem in webrtc-rs/interceptor#5

Copy link
Member

@algesten algesten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge away.

@k0nserv
Copy link
Member Author

k0nserv commented Aug 24, 2022

Wanna see if CI passes first :)

@codecov
Copy link

codecov bot commented Aug 24, 2022

Codecov Report

Merging #258 (17819b6) into master (1614c3b) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master     #258      +/-   ##
==========================================
- Coverage   56.05%   56.04%   -0.01%     
==========================================
  Files         500      500              
  Lines       46523    46525       +2     
  Branches    12714    12714              
==========================================
- Hits        26077    26075       -2     
+ Misses       9922     9921       -1     
- Partials    10524    10529       +5     
Impacted Files Coverage Δ
interceptor/src/report/receiver/receiver_test.rs 65.97% <50.00%> (-0.09%) ⬇️
webrtc/src/mux/mux_func.rs 74.07% <0.00%> (-3.71%) ⬇️
sctp/src/timer/ack_timer.rs 79.31% <0.00%> (-3.45%) ⬇️
rtp/src/header.rs 62.37% <0.00%> (-1.55%) ⬇️
dtls/src/lib.rs 73.33% <0.00%> (ø)
dtls/src/state.rs 69.56% <0.00%> (ø)
sdp/src/description/session.rs 62.57% <0.00%> (ø)
util/src/vnet/conn/conn_test.rs 53.38% <0.00%> (ø)
ice/src/agent/agent_internal.rs 63.15% <0.00%> (+0.14%) ⬆️
ice/src/agent/agent_gather_test.rs 56.56% <0.00%> (+0.31%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@k0nserv
Copy link
Member Author

k0nserv commented Aug 24, 2022

This seems like an improvement, but we have tests on Windows that will run forever due to similar issues. I've stopped the Windows builds to not hog those machines.

I also created an issue to tackle this in other parts of the project.

@k0nserv k0nserv merged commit 1366261 into master Aug 24, 2022
@k0nserv k0nserv deleted the fix/another-attempt-at-fixing-flakey-ubuntu-tests branch August 24, 2022 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants