fix(dedupe): batch_size>512 丢记录（部分修复，见 #1） - #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
针对 #10 的热修（v2.4.1）：
_flush()中滑动窗口 key-set 清理时机错误（原实现把窗口边界算错一格）；batch_size > 512时窗口状态与 key-set 仍不同步（见 dedupe: batch_size>512 在 v2.4.1 后仍丢记录（#1 未修复） #26），完整修复在 fix(dedupe): 完整修复 batch_size>512（含 1024 边界测试） #73。Partially fixes #10