Skip to content

Conversation

@droark
Copy link

@droark droark commented Dec 2, 2016

When compiling using the -Wshadow compiler flag, quite a few warnings pop up. Clean up all instances of shadowing.

When compiling using the -Wshadow compiler flag, quite a few warnings pop up. Clean up all instances of shadowing.
@noloader
Copy link
Collaborator

noloader commented Mar 14, 2017

@droark,

Sorry about the late reply here. I seem to do that to you more than you deserve.

I think we should pass on this at the moment. I think prefixing parameters with _ adds more diversity, and I think we should strive for consistency and not diversity. I think the way to proceed is to prefix the struct or class member with m_. The library seems to favor that style the most.

Maybe a patch that applies the m_ style to all classes and structs would benefit the library the most at this point. I believe it would add the most consistency, and avoid the shadow warnings.

@droark
Copy link
Author

droark commented Mar 15, 2017

@noloader - No worries. I'll look into it when I get a chance. It could be awhile. For now, I'll close this out and reopen it later if necessary.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants