Add Active category to Hacker News feed

[weiran]

Description:

Summary

• Add new "Active" category to the feed selector that shows posts with
  recent activity/discussion
• Fetches data from https://news.ycombinator.com/active
• Includes proper pagination support using page-based navigation

Changes

• Added active case to PostType enum in Models.swift
• Added "Active" title and bolt icon in HackersKitExtensions.swift
• Implemented URL handling and pagination for Active feed in
  HackersKit+PostsList.swift

Test plan

• Build compiles successfully for iOS Simulator
• Active category appears in the feed selector dropdown
• Active feed loads posts from the correct URL
• Pagination works when scrolling to bottom of Active feed
• Manual testing on device/simulator to verify UI and functionality

🤖 Generated with Claude Code

Summary by CodeRabbit

• New Features
  • Introduced support for an "Active" post type, including a new icon and title.
  • Added the ability to fetch and display "Active" posts with dedicated handling in the app.

[coderabbitai]

Walkthrough

A new .active case was added to the PostType enum, with corresponding updates to its title and iconName computed properties. The fetchPostsHtml method was updated to handle the .active type with a specific URL pattern. No other logic or public API changes were made.

Changes

Cohort / File(s)	Change Summary
PostType enum and extensions Shared Frameworks/HackersKit/Models/Models.swift, App/Extensions/HackersKitExtensions.swift	Added .active case to PostType enum; updated title and iconName computed properties to support .active.
Post fetching logic Shared Frameworks/HackersKit/HackersKit+PostsList.swift	Modified fetchPostsHtml to add a dedicated URL construction branch for .active post type.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Poem

A new post type hops into view,
With "Active" in title, and a bolt shining through!
The fetcher now knows just where to look,
For lively posts in the digital nook.
With enums extended and icons anew,
This rabbit winks—there’s more to do!
⚡🐇

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 286ab45 and 2ba4a05.

📒 Files selected for processing (3)

• App/Extensions/HackersKitExtensions.swift (2 hunks)
• Shared Frameworks/HackersKit/HackersKit+PostsList.swift (1 hunks)
• Shared Frameworks/HackersKit/Models/Models.swift (1 hunks)

🔇 Additional comments (4)

Shared Frameworks/HackersKit/Models/Models.swift (1)

63-63: LGTM! Clean enum extension.

The addition of the .active case follows the established pattern and maintains consistency with the String raw value approach.

App/Extensions/HackersKitExtensions.swift (2)

26-26: Appropriate title choice.

"Active" clearly communicates the purpose of this feed category and follows the established naming convention.

---

38-38: Good icon selection.

The "bolt" SF Symbol effectively represents activity and energy, making it intuitive for users to identify the Active feed.

Shared Frameworks/HackersKit/HackersKit+PostsList.swift (1)

28-29: Correct URL construction and pagination handling.

The implementation properly handles the Active feed with page-based pagination, consistent with the existing pattern for most post types. The URL construction matches the expected Hacker News endpoint.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch active-posts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.