Merged
Conversation
Adds Roslyn analyzer support for parsing type names passed to Type.GetType. Reapplies e5b1d02 which was reverted due to #106321. Now that Roslyn has updated to reference System.Reflection.Metadata 9.0, we could use `TypeName` from that assembly. However, the code was using `TypeNameHelpers.Unescape` which was moved to `TypeName.Unescape` in .NET 10. Instead of using the 9.0.0 version, this just source includes the sources for the TypeNameResolver to ensure we get the same behavior in the analyzer as we have in ILC/ILLink.
This PR fixes assertion failures when stepping in the Mono debugger on ARM64 by aligning the breakpoint address calculation logic with the AMD64 implementation. The changes remove the division by 4 that was causing incorrect indexing into the breakpoint addresses array.
…#118414) * Index CordbModule using module instead of domain assembly * Ensure domain assembly is non-null in CordbModule
) Long-running enumerator loops at Tier0+instr will see their executions transition over to a non-instrumented OSR version of the code. This can cause loss of PGO data in the portions of the method that execute after the leaving the loop that inspires OSR. For enumerator vars we can safely deduce the likely classes from probes made earlier in the method. So when we see a class profile for an enumerator var, remember it and use it for subsequent calls that lack their own profile data. Addresses part of #118420.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.3)
Can you help keep this open source service alive? 💖 Please sponsor : )