fix: use huggingface_hub Python API for model pull#2
Merged
Conversation
Replace the subprocess shell-out to hf/huggingface-cli with a direct call to huggingface_hub.snapshot_download. This fixes pull failures when mlx-stack is installed via uv tool or pipx, where dependency entry-points are not exposed on PATH. Also drops the nonexistent [cli] extra from the huggingface-hub dependency. Fixes #1 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
12 tasks
weklund
added a commit
that referenced
this pull request
Apr 4, 2026
## Summary - Adds `permissions: contents: read` to `ci.yml`, `integration-nightly.yml`, and `integration-prerelease.yml` - Resolves all 4 open CodeQL code-scanning alerts ([#1](https://github.com/weklund/mlx-stack/security/code-scanning/1), [#2](https://github.com/weklund/mlx-stack/security/code-scanning/2), [#3](https://github.com/weklund/mlx-stack/security/code-scanning/3), [#4](https://github.com/weklund/mlx-stack/security/code-scanning/4)) - Follows least-privilege principle — these workflows only need read access to checkout code and run tests - `release-please.yml` and `publish.yml` already had explicit permissions ## Test plan - [ ] CI passes on this PR (confirms `contents: read` is sufficient) - [ ] CodeQL re-scan shows alerts resolved after merge 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hf/huggingface-cliwith a direct call tohuggingface_hub.snapshot_download, which is already a declared dependency[cli]extra from thehuggingface-hubdependency inpyproject.toml_resolve_hf_cli(),_filter_traceback(), and associated subprocess plumbing_run_downloaduses the Python API and does not shell out to CLI binariesFixes #1
Test plan
TestRunDownloadUsesSnapshotDownloadclass guards against regression:snapshot_downloadis called with correctrepo_idandlocal_dirDownloadErrorsubprocess/Popen/shutil.whichusage_resolve_hf_cliand_filter_tracebackhelpers are removed🤖 Generated with Claude Code