Skip to content

Comments

Add post about pushing images to Azure#11

Merged
bcl merged 2 commits intoweldr:masterfrom
stefwalter:azure-composer-post
Oct 12, 2018
Merged

Add post about pushing images to Azure#11
bcl merged 2 commits intoweldr:masterfrom
stefwalter:azure-composer-post

Conversation

@stefwalter
Copy link

@stefwalter stefwalter commented Oct 8, 2018

Depends on the following being merged first:

@stefwalter stefwalter force-pushed the azure-composer-post branch from 7446777 to 50c82a9 Compare October 8, 2018 14:53
Copy link

@bcl bcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar small changes

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as on AWS post, Permissive

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lorax-composer.socket

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are using F29, but say yum here instead of dnf.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like the documentation to work for RHEL as much as possible. Yum works on both.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Back to composer-cli (or whatever we decide if different)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@bcl
Copy link

bcl commented Oct 8, 2018

There also seems to be a missing image, I get this from Jekyll
ERROR `/images/cockpit-composer-azure-download.png' not found.

@stefwalter stefwalter changed the title Add post about pushing images to Azure WIP: Add post about pushing images to Azure Oct 9, 2018
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a bit of a nitpick, but should this have consistent naming with the images below, as in cockpit-composer-azure-create.png?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@stefwalter
Copy link
Author

stefwalter commented Oct 12, 2018

Thanks @poncovka for the fixup! Squashed it in.

@stefwalter
Copy link
Author

There also seems to be a missing image, I get this from Jekyll ERROR `/images/cockpit-composer-azure-download.png' not found.

Fixed. We don't need this image.

@stefwalter stefwalter changed the title WIP: Add post about pushing images to Azure Add post about pushing images to Azure Oct 12, 2018
@stefwalter
Copy link
Author

This is ready now. Tested as well.

@bcl
Copy link

bcl commented Oct 12, 2018

Thanks!

@bcl bcl merged commit 08004f0 into weldr:master Oct 12, 2018
@stefwalter stefwalter deleted the azure-composer-post branch October 16, 2018 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants