Finish the Node 20 removal: upload-pages-artifact was hiding one too - #29
Merged
Merged
Conversation
The previous commit left upload-pages-artifact at v3 and asserted it "has no Node 20 problem to solve". The first Docs run on main disproved that: Node.js 20 is deprecated. The following actions target Node.js 20 ...: actions/upload-artifact@v4 v3 is a composite, and the deprecated runtime is the action it wraps — so it never appears when you grep the workflow for versions, and the warning only surfaces on main, where Docs runs. v5 pins upload-artifact@v7. I had skipped v4+ over its dotfile change, which was a guess. Checking instead: the artifact from the last successful deploy holds 4,914 entries and not one of them is hidden, so `include-hidden-files` can stay at its default. The comment now records that, and points at the input to set if DocC ever emits one. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #28, which I got partly wrong.
#28 left
upload-pages-artifactat v3 and claimed it "has no Node 20 problem to solve." The first Docs run onmainafter that merge said otherwise:v3 is a composite action, so the deprecated runtime belongs to the action it wraps. It never shows up when you grep the workflow for versions, and the annotation only appears on
main, where Docs runs — which is why #28's own PR checks came back clean.upload-pages-artifact@v5pinsupload-artifact@v7(Node 24).The reason I skipped v4+ was its dotfile change, and that reason was a guess. So I checked it instead: pulled the
github-pagesartifact from the last successful deploy and listed it. 4,914 entries, zero hidden files.transform-for-static-hostingdoesn't emit any, soinclude-hidden-filescan stay at its default and the bump is free. The comment now records the measurement and names the input to set if DocC ever starts emitting one.After this, nothing in
.github/workflows/runs on Node 20 — including one level down.