Bump agentic-pr-review to v1.1.0 and drop the hand-rolled MiniMax review - #29
Conversation
Picks up repository review memory, the oversized-PR skip, the skip-review label, and removal of the action's telemetry. The workflow already grants issues: write, which the new memory issue requires.
The agentic-pr-review action covers the same ground, so every pull request was getting two independent review passes. MINIMAX_API_KEY is still used by the OpenHands workflow.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
🟢 Good taste — clean migration to the maintained action and removal of the duplicate hand-rolled review.
Previous review follow-up — this is the first marked review on this PR; no prior findings to classify.
Verification performed:
- Pinned SHA
7c6c9079…resolves to the commit the v1.1.0 annotated tag points to (tag authored bywende@hey.com). Tag is unsigned, but the SHA pin is the actual trust anchor, matching the v1.0.0 pattern. - The maintainer of
wende/agentic-pr-reviewis the same as the reviewed repo (wende), so this is a first-party action — the 7-day waiting rule does not apply, and supply-chain risk is unchanged from v1.0.0 (same author, same pin style, same input surface). - All four inputs in
openhands-pr-review.yml(llm-model,llm-base-url,llm-api-key,github-token) are still valid in v1.1.0; the newissues: writepermission requirement is already present in the workflow. - No dangling references to the deleted
minimax-pr-review.yml,ai-review.mjs, orminimax-pr-review.mdremain in the tree. - CI:
Testsworkflow run onchore/agentic-review-1.1.0succeeded;OpenHands PR Reviewis actively exercising the bumped v1.1.0 action on this PR.
Behaviour notes from v1.1.0 already covered in the PR description (no action needed from the author): repo memory issue will be auto-created on first run, skip-review label still starts a runner, iterations wrap at 40 / hard-cap 60, dead lmnr-api-key input cleared.
[RISK ASSESSMENT]
[Overall PR]
VERDICT: ✅ Worth merging — straightforward cleanup; the maintained action supersedes the hand-rolled script and the bump is consistent with prior pinning hygiene.
What changed
.github/workflows/openhands-pr-review.ymlnow pinswende/agentic-pr-reviewat7c6c907(v1.1.0), up from1f5bd01(v1.0.0). Same SHA-pin + version-comment style as before..github/workflows/minimax-pr-review.yml,.github/scripts/ai-review.mjs, and.github/prompts/minimax-pr-review.md. Both.github/scripts/and.github/prompts/are gone, since those were their only contents.Why
Every pull request was getting two independent AI review passes — the action and the hand-rolled script — covering the same ground. The action is the maintained path, so the script version goes.
Reviewer notes
llm-model,llm-base-url,llm-api-key,github-token) is still valid in v1.1.0. The removedlmnr-api-keyinput was never passed here.issues: writewas already granted, which v1.1.0's new memory feature requires — so no permission change either.MINIMAX_API_KEYis still in use by the OpenHands workflow; do not remove the secret.Behaviour changes that come with v1.1.0, with no config edits
skip-reviewis skipped. Note this repo does not short-circuit at the job level, so such a PR still starts a runner and skips inside the action — worth adding later if the label sees real use.